Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Plugins as Hooks #3867

Merged
merged 2 commits into from Oct 29, 2018
Merged

Rename Plugins as Hooks #3867

merged 2 commits into from Oct 29, 2018

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Oct 29, 2018 •
edited

Changelog: Fix: Renamed Plugins as Hooks

  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@ghost ghost assigned danimtb Oct 29, 2018
@ghost ghost added the stage: review label Oct 29, 2018
@danimtb danimtb mentioned this pull request Oct 29, 2018
Merged
@danimtb danimtb added this to the 1.9 milestone Oct 29, 2018
@danimtb danimtb assigned jgsogo and unassigned danimtb Oct 29, 2018
@jgsogo jgsogo mentioned this pull request Oct 29, 2018
Closed
jgsogo
jgsogo approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for the related change in docs.

@jgsogo
Copy link
Contributor

jgsogo commented Oct 29, 2018

Just seen them, it was already merged 🤦‍♂️

@jgsogo jgsogo merged commit 2339378 into conan-io:develop Oct 29, 2018
@ghost ghost removed the stage: review label Oct 29, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@danimtb @jgsogo
Rename Plugins as Hooks (conan-io#3867)
9d064e7 
* Rename Plugins as Hooks

* Migration from plugins to hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danimtb @jgsogo @memsharded